Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose testing functions as public API #24

Merged
merged 7 commits into from
Aug 24, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Aug 22, 2020

As suggested in #11, this exposes assert_units_equal as public API (as pint_xarray.testing.assert_units_equal). I don't think we have more of those, but if we do they should be added here, too.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   86.91%   87.25%   +0.33%     
==========================================
  Files           7        9       +2     
  Lines         688      706      +18     
==========================================
+ Hits          598      616      +18     
  Misses         90       90              
Impacted Files Coverage Δ
pint_xarray/__init__.py 100.00% <100.00%> (ø)
pint_xarray/testing.py 100.00% <100.00%> (ø)
pint_xarray/tests/test_testing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226f747...52e9e87. Read the comment docs.

@keewis
Copy link
Collaborator Author

keewis commented Aug 22, 2020

the docstring could use a review, but otherwise this is ready for review and merge

@keewis keewis mentioned this pull request Aug 22, 2020
16 tasks
Copy link
Collaborator

@jthielen jthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, just a couple small questions/suggestions on the docstring.

pint_xarray/testing.py Outdated Show resolved Hide resolved
pint_xarray/testing.py Outdated Show resolved Hide resolved
@keewis keewis mentioned this pull request Aug 23, 2020
7 tasks
keewis and others added 2 commits August 23, 2020 21:26
@jthielen jthielen merged commit 4347a32 into xarray-contrib:master Aug 24, 2020
@keewis keewis deleted the testing branch August 24, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants