-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose testing functions as public API #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 86.91% 87.25% +0.33%
==========================================
Files 7 9 +2
Lines 688 706 +18
==========================================
+ Hits 598 616 +18
Misses 90 90
Continue to review full report at Codecov.
|
the docstring could use a review, but otherwise this is ready for review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, just a couple small questions/suggestions on the docstring.
Co-authored-by: Jon Thielen <[email protected]>
Co-authored-by: keewis <[email protected]>
As suggested in #11, this exposes
assert_units_equal
as public API (aspint_xarray.testing.assert_units_equal
). I don't think we have more of those, but if we do they should be added here, too.