Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facetgrid #83

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Facetgrid #83

wants to merge 18 commits into from

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Sep 17, 2020

Address #79

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #83 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files           7        7           
  Lines         800      800           
=======================================
  Hits          737      737           
  Misses         63       63           
Flag Coverage Δ
#unittests 92.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/accessor.py 92.96% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235acac...b4a9a18. Read the comment docs.

@dcherian
Copy link
Contributor

dcherian commented Dec 16, 2020

Julia, I think the issue may be the wrap_classes arg which is False by default. We want to set it to True for facetgrid plots.

if wrap_classes and isinstance(result, _WRAPPED_CLASSES):
result = _CFWrappedClass(result, accessor)

EDIT: I don't actually remember why this was added. Set to True by default and see if tests pass?

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #83 (1833a22) into main (e11cf07) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1833a22 differs from pull request most recent head 8e8b239. Consider uploading reports for the commit 8e8b239 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   96.39%   96.38%   -0.01%     
==========================================
  Files          14       14              
  Lines        1635     1631       -4     
==========================================
- Hits         1576     1572       -4     
  Misses         59       59              
Flag Coverage Δ
unittests 96.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/accessor.py 95.17% <ø> (ø)
cf_xarray/tests/test_accessor.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11cf07...8e8b239. Read the comment docs.

@dcherian
Copy link
Contributor

assert isinstance(rv, xr.plot.FacetGrid)

This test should be changed; we aren't returning pure FacetGrid instances anymore.

@jukent
Copy link
Contributor Author

jukent commented Dec 16, 2020

assert isinstance(rv, xr.plot.FacetGrid)

This test should be changed; we aren't returning pure FacetGrid instances anymore.

That makes sense. I'm not 100% sure what the instances should be yet so I won't change it - at least until I have it working locally.

@dcherian
Copy link
Contributor

We can just delete that line and make sure that plotting followed by map_dataarray works.

@jukent
Copy link
Contributor Author

jukent commented Dec 16, 2020

We can just delete that line and make sure that plotting followed by map_dataarray works.

There are 3 lines identical to that (on 298, 302, and 312). Should we delete each of these tests?

@dcherian
Copy link
Contributor

yes unless you have ideas for something to test.

* main: (57 commits)
  Add CITATION.cff, tributors, zenodo.json (xarray-contrib#231)
  Add zenodo badge
  Improve `rename_like` (xarray-contrib#222)
  Don't apply mappers to DataArrays (xarray-contrib#227)
  Add unit support to cf-xarray (xarray-contrib#197)
  Update README.rst
  Add earthcube 2021 notebook link to readme
  v0.5.2
  Some CMIP6 support
  Add pooch to binder environment (xarray-contrib#223)
  `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221)
  Add .cf.formula_terms (xarray-contrib#213)
  Update whats-new.rst (xarray-contrib#217)
  add bounds property (xarray-contrib#214)
  Update some tests.
  Compile regexes
  Fix black
  Add __version__ (xarray-contrib#208)
  add skip to rename_like (xarray-contrib#206)
  Refactor out coordinate criteria to criteria.py (xarray-contrib#205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants