Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library fix and annotation fix #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neeleshverma
Copy link

numpy should be used instead of math for better precision and a small annotation fix.

Copy link

@Madhav-MKNC Madhav-MKNC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes:

  • Replacing math.prod with np.prod is acceptable if the numpy package is imported.
  • Addition of params_only: bool parameter requires updates to function calls and documentation.

Recommendations:

  • Ensure unit tests are updated for the new changes.
  • Confirm the changes align with the system's design and do not introduce regressions.

If the above points are addressed, proceed with merging the PR after successful CI checks.

@neeleshverma
Copy link
Author

The "params_only" parameter is already there in the function. I simply added the type (bool) to make the function declaration clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants