-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TopicData
overhaul and hierarchical clustering
#78
Conversation
…stead of TypedDict
…entiated it to ensure nonnegativity
TopicData
overhaul and hierarchical clustering
TopicData
overhaul and hierarchical clusteringTopicData
overhaul and hierarchical clustering
I have also removed the changelog from the readme. I will add it later into the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally really like this change - not much to add. I think the topic data abstraction seem solid.
I think it is a great case of a fairly simple container that provides a lot of utility.
This PR is made to extend
TopicData
's functionality for ease of use, and to be able to save data about dynamic and hierarchical models.This update is meant to be backwards compatible both with Turftopic and topicwizard, and I want to introduce more flexibility to the
TopicData
API rather than restricting it.I've also added full support for cluster hierarchies in clustering topic models, which was a last missing piece of the puzzle to take the library to a place where it can reasonably compete with Top2Vec and BERTopic.