Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sub navigation component in Prototype Kit template #211

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

paulrobertlloyd
Copy link
Contributor

The sub navigation template provided to the Prototype Kit currently shows an incorrect state, with a parent without children being shown as current, but then children for a parent being show which is not current. To demonstrate both children and current items, this PR moves the currently active item to one of the child pages.

Before After
Screenshot of sub navigation showing incorrect item highlighting. Screenshot of sub navigation showing correct item highlighting.

@paulrobertlloyd paulrobertlloyd merged commit 7b9c36d into main Jan 24, 2024
2 checks passed
@paulrobertlloyd paulrobertlloyd deleted the fix-prototype-kit-sub-navigation-example branch January 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants