Simplify poll handling of prematurely deleted job log dir #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Feb 14, 2025
Comment on lines
-756
to
-765
| # A polling task lets us know that a task has failed because it's | ||
| # log folder has been deleted whilst the task was active: | ||
| if ( | ||
| getattr(ctx, 'out', None) | ||
| and JOB_FILES_REMOVED_MESSAGE in ctx.out | ||
| ): | ||
| LOG.error( | ||
| f'Task {ctx.cmd[-1]} failed because task log directory' | ||
| f'\n{"/".join(ctx.cmd[-2:])}\nhas been removed.' | ||
| ) |
There was a problem hiding this comment.
I have moved this error logging into the _poll_task_job_callback method seeing as it only applies for poll, not kill or submit which also use this _manip_task_jobs_callback method
MetRonnie
commented
Feb 14, 2025
Comment on lines
884
to
-882
| self.task_events_mgr.process_message( | ||
| itask, log_lvl, TASK_OUTPUT_FAILED, jp_ctx.time_run_exit, flag) |
There was a problem hiding this comment.
This was a duplication of what the next line does anyway
cylc/cylc/flow/task_events_mgr.py
Lines 788 to 802 in 5b2b180
8 tasks
MetRonnie
commented
Feb 14, 2025
| # Main loop is roughly 1 second, but integer rounding may give an apparent 2 | ||
| # seconds delay, so set threshold as 2 seconds. | ||
| run_ok "${TEST_NAME_BASE}-poll-time" \ | ||
| cmp_times "${PREDICTED_POLL_TIME}" "${ACTUAL_POLL_TIME}" '10' |
There was a problem hiding this comment.
This test was horribly flaky for me locally on 8.4.x. Also the timings test was so loose so as to be pointless (threshold was at some point set to 10s instead of 2s as mentioned in the comment). I don't think it's feasible to test the timings
wxtim
approved these changes
Feb 17, 2025
wxtim
merged commit 749ff2f
into
wxtim:fix.handle_deletion_of_job_logs
24 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.