Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use sub-dependency binaries directly #482

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Feb 23, 2024

This closes #479. Verified both PNPM and NPM work as expected now.

  • To fix the wxt submit error, I had to create a new bin file that imports publish-browser-extension's CLI so it always gets added to node_modules/.bin
  • To fix the rollup-plugin-visualizer error, I had to release a fork of my PR with JS API for merging outputs together, not relying on the CLI anymore.

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 36ba914
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65d9116020863d00084d1463
😎 Deploy Preview https://deploy-preview-482--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.83%. Comparing base (707f03a) to head (36ba914).

Files Patch % Lines
src/cli/cli-utils.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   85.96%   85.83%   -0.13%     
==========================================
  Files         106      105       -1     
  Lines        8278     8255      -23     
  Branches      814      812       -2     
==========================================
- Hits         7116     7086      -30     
- Misses       1149     1156       +7     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 self-assigned this Feb 23, 2024
@aklinker1 aklinker1 added the bug Something isn't working label Feb 23, 2024
@aklinker1 aklinker1 marked this pull request as ready for review February 23, 2024 21:43
@aklinker1 aklinker1 changed the title fix: Fix wxt submit "Cannot find module" error fix: Don't load sub-dependency binaries Feb 23, 2024
@aklinker1 aklinker1 changed the title fix: Don't load sub-dependency binaries fix: Don't use sub-dependency binaries directly Feb 23, 2024
@aklinker1 aklinker1 merged commit c0dbffa into main Feb 23, 2024
17 checks passed
@aklinker1 aklinker1 deleted the improve-command-aliases branch February 23, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wtx submit init not finding publish-browser-extension
1 participant