Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Speck into its own package. #63

Open
wants to merge 35 commits into
base: gh-pages
Choose a base branch
from
Open

Move Speck into its own package. #63

wants to merge 35 commits into from

Conversation

shammamah-zz
Copy link

This adds all of the shader files and adds a file interactions.js that captures the user interactions with the canvas.

Shammamah Hossain and others added 30 commits November 22, 2018 09:38
Add files such that there is no longer a dependence on fs; write inte…
0f6ec4f 
…ractions.js to handle window interactions.
Remove unnecessary files, update package.json, and configure webpack …
cfabe23 
…and index.js.
Refactor code to account for interactions being moved out of props an…
893f57c 
…d into state.
Fix ambient occlusion not updating during rotation.
dbf980c
Refresh view on mouse move.
19536f4
Change mouse interaction action to reset lastX and lastY.
2f93e11
Allow for the option of using mouse wheel to zoom.
a746ea9
Include view presets in exports.
95a865f
Fix issue with position changing before rotation.
bee55e7
Remove component.prop mutation and replace with setProp equivalent an…
dacd2e9 
…d simplify zoom code
Prevent page from scrolling while zooming
f8f52e3
Fix behaviour related to moving cursor in and out of speck element
768d286
Add early return for mouseup when component is not in buttonDown === …
d8d14fa 
…true state
Fixed formatting
df019c2
Prevent props from being directly passed into function which mutates arg
e49606e
Merge pull request #1 from plotly/manfred/remove_component_prop_mutate
94aa774 
Remove component.prop mutation
Merge branch 'master' into manfred/prevent_scroll
cfa6523
Merge pull request #2 from plotly/manfred/prevent_scroll
8f602a7 
Prevent page from scrolling while zooming
Merge pull request #3 from plotly/manfred/improved_interaction_behaviour
70a358d 
Fix behaviour related to moving cursor in and out of speck element
Fix styling errors in interactions.js
9698f35
Interactions returns a function which removes all added event listeners
0cda2db
Rewrite interactions.js to be app implementation agnostic
c5e2346
Add failsafe to prevent rotation when main mouse button lifted
9023a8e
Remove all ES6
da9df7b
Add error to warn users using the new Speck library with old dash-bio…
d883226 
… app etc.
Use strict equality instead of equality
0af93f5
Prevent interaction with other page elements while rotating molecule …
7e3cb09 
…(which might interfere with rotation)
Throw error if arg object is not provided
c36e1a8
Add support for Speck translation
9ba96c2
Merge pull request #4 from plotly/manfred/polish_interaction_code
27ff7ef 
Manfred/polish interaction code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shammamah-zz @nickmelnikov82 @HammadTheOne @gvwilson