-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support library development on an M1 mac #107
Conversation
…s because its not supported - TT RAG Co-authored-by: Tyler Thompson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 65 65
Lines 1680 1680
=======================================
Hits 1593 1593
Misses 87 87 Continue to review full report at Codecov.
|
According to this issue: mattgallagher/CwlPreconditionTesting#21 we are unable to use CwlPreconditionTesting on ARM based devices (like the M1 macs). |
…sors. - RAG TT Co-authored-by: Tyler Thompson <[email protected]>
There was one more change I had to do, but I believe it is on the person who has an M1 to do. SwiftLint from the command line failed because something was misconfigured. A quick google search later got me fixed up with the solution in this issue: realm/SwiftLint#1466 |
Thanks for this useful code. I copied it to a standalone project so that I could work out some details to make the build settings work as a package used by multiple test targets. I needed it to prepare this PR to support Apple Silicon. |
@Richard-Gist I packaged up these functions to make them easy to use as a dependency. It currently points to a forked branch which has the fix thanks for Saagar. I also have these functions limited to iOS and macOS since the underlying library only includes those 2 platforms. For other platforms it just skips them. |
Linked Issue:
Checklist: