Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support library development on an M1 mac #107

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

Richard-Gist
Copy link
Collaborator

@Richard-Gist Richard-Gist commented Aug 12, 2021

Linked Issue:

Checklist:

…s because its not supported - TT RAG

Co-authored-by: Tyler Thompson <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #107 (a3bc0bc) into main (082b711) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          65       65           
  Lines        1680     1680           
=======================================
  Hits         1593     1593           
  Misses         87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1925808...a3bc0bc. Read the comment docs.

@Richard-Gist
Copy link
Collaborator Author

According to this issue: mattgallagher/CwlPreconditionTesting#21 we are unable to use CwlPreconditionTesting on ARM based devices (like the M1 macs).

@Richard-Gist Richard-Gist added the enhancement New feature or request label Aug 12, 2021
@Richard-Gist Richard-Gist marked this pull request as ready for review August 12, 2021 23:04
@Richard-Gist
Copy link
Collaborator Author

There was one more change I had to do, but I believe it is on the person who has an M1 to do. SwiftLint from the command line failed because something was misconfigured. A quick google search later got me fixed up with the solution in this issue: realm/SwiftLint#1466

@brianlombardo brianlombardo merged commit 445dde6 into main Aug 13, 2021
@brianlombardo brianlombardo deleted the m1-prep branch August 13, 2021 16:18
@brennanMKE
Copy link

Thanks for this useful code. I copied it to a standalone project so that I could work out some details to make the build settings work as a package used by multiple test targets. I needed it to prepare this PR to support Apple Silicon.

@brennanMKE
Copy link

@Richard-Gist I packaged up these functions to make them easy to use as a dependency. It currently points to a forked branch which has the fix thanks for Saagar. I also have these functions limited to iOS and macOS since the underlying library only includes those 2 platforms. For other platforms it just skips them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants