-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some improvements #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the changes to make the assignment better!
README.md
Outdated
* `Truck`: `sale_price() + (sale_price() * 1.7 / length_in_months)` | ||
* `Car`: `sale_price() * 1.2 / length_in_months`. | ||
* `Motorcycle`: `sale_price() * 1 / length_in_months` | ||
* `Truck`: `sale_price() * 1.7 / length_in_months` | ||
|
||
The `monthly_value` of the contract will be just the total value divided by the amount of months: `total_value() / length_in_months`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for spotting and correcting the mistake !
@@ -23,6 +23,7 @@ var/ | |||
*.egg-info/ | |||
.installed.cfg | |||
*.egg | |||
venv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! added this as well..
No description provided.