Hangman assignment #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeyim
reviewed
May 23, 2018
|
|
||
| # Complete with your own, just for fun :) | ||
| LIST_OF_WORDS = [] | ||
| LIST_OF_WORDS = ['cookies', 'cream', 'love', 'vinegar'] |
| if list_of_words == []: | ||
| raise InvalidListOfWordsException | ||
| else: | ||
| return random.choice(list_of_words) |
There was a problem hiding this comment.
very clean code here ... random library is perfect for this...
| if word == "": | ||
| raise InvalidWordException | ||
| else: | ||
| return len(word)*"*" |
| raise InvalidGuessedLetterException(Exception) | ||
| if len(masked_word) != len(answer_word): | ||
| raise InvalidWordException | ||
| if answer_word =="" or masked_word =="" : |
There was a problem hiding this comment.
it's possible to combine all conditions in line 41 with "or" for the same InvalidWordException
| #convert answer_word and character to lower case | ||
| lower_character = str.lower(character) | ||
| lower_answer = str.lower(answer_word) | ||
| if lower_character not in lower_answer: |
There was a problem hiding this comment.
we can remove line 48 and 49 since there's no change to masked_word ... notice line 55 will return masked_word anyway ...
| if lower_character in lower_answer: | ||
| indices=find_substring(lower_answer, lower_character) | ||
| for index in indices: | ||
| masked_word = masked_word[:index] + lower_character + masked_word[index + 1:] |
| raise GameFinishedException | ||
| else: | ||
| #make game case insensitive by converting all strings to lower case | ||
| letter = str.lower(letter) |
There was a problem hiding this comment.
good idea to lowercase the letter and answer_word here.. which means you can remove the lowercase at _uncover_word() function ...!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code review