add mssql dns alias resource support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magodo
reviewed
May 6, 2022
internal/services/mssql/mssql_server_dns_alias_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource_test.go
Outdated
Show resolved
Hide resolved
wuxu92
force-pushed
the
feat_sqldnsalias
branch
4 times, most recently
from
67e8432 to
ab71ed6
Compare
magodo
suggested changes
May 7, 2022
|
@magodo all comments fixed |
wuxu92
force-pushed
the
feat_sqldnsalias
branch
7 times, most recently
from
804d02a to
6ceddee
Compare
Co-authored-by: kt <[email protected]>
wuxu92
pushed a commit
that referenced
this pull request
Jul 14, 2023
wuxu92
pushed a commit
that referenced
this pull request
Nov 28, 2024
…ce features (hashicorp#26606) * added 'enhanced_security_compliance' block to databricks workspace schema * added customized diff checks to verify databricks workspace 'enhanced_security_compliance' block * added premium sku check for databricks workspace 'enhanced_security_compliance' * added 'enhanced_security_compliance' block to read and create/update methods * documented new 'enhanced_security_compliance' block for 'azurerm_databricks_workspace' resource * Fixed bugs, added acceptance test * Fix schema linting check * Added data source support and corresponding acctest * PR feedbacks improvements #1: - Always set value into state - Simplified expansion logic - Acctests method renaming to conform with standards - Removed unnecessary parameterisation of acctest config method - Docs for datasource * PR feedbacks improvements 2: - Removed stray newline - Use pointer.From to prevent nil deref - Improved validation error msg * PR feedbacks improvements 3: - Replace single-quote with backticks on error messages - Remove RequiredWith from compliance_security_profile_standards - Remove redundant test checks - Improve datasource docs - Add 'defaults to' to resource doc --------- Co-authored-by: Gerry Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.