Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hsp alignment download reformat #603

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

iQuxLE
Copy link
Contributor

@iQuxLE iQuxLE commented Jun 5, 2022

FASTA headers of the downloaded HSP alignments now show the hit number and hsp number (in letters) that the user is currently looking at.

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iQuxLE iQuxLE closed this Jun 5, 2022
@iQuxLE iQuxLE reopened this Jun 5, 2022
@yannickwurm
Copy link
Member

Hey @iQuxLE - do these code climate need to be fixed? or are they minor?

And/or are they related to the conflicts that need to be resolved. Are you able to resolve those?

@iQuxLE
Copy link
Contributor Author

iQuxLE commented Jun 17, 2022

I suppose the issues are more minor. It is just a duplication in two locations and minimizing that won't make it more intuitive and easier to understand.

@yannickwurm
Copy link
Member

Are you able to tell Codeclimate to ignore those minor issues (through local in-line ignore/reconfig comments?)

iQuxLE added 7 commits June 30, 2022 12:14
changing threshold to avoid similar code in sidebar.js
updated codeclimate.yml with a filter to prevent duplication call for sidebar.js
@iQuxLE
Copy link
Contributor Author

iQuxLE commented Jul 1, 2022

I added filters for the specific functions inside alignment_exporter.js and sidebar.js
These filters use the parsing tree to allow codeclimate to prevent a duplication call as these are minor duplications.
By that we don't need to change the mass_threshold which would affect all files in sequenceserver.

@yeban
Copy link
Collaborator

yeban commented Jul 11, 2022

Given the number of 'Update xyz' kind of commits, it may be desirable to squash-and-merge this PR. That would be git merge --squash on the command line, but also GitHub would offer this option when the remaining file conflict is resolved.

@yannickwurm
Copy link
Member

@iQuxLE
Screenshot 2022-07-31 at 22 31 31

@iQuxLE
Copy link
Contributor Author

iQuxLE commented Aug 1, 2022

I think I have not used the most recent commit that's why there is a conflict cause I don't see the details for this. Let me check the next days.

@yannickwurm
Copy link
Member

yannickwurm commented Aug 1, 2022 via email

@yannickwurm
Copy link
Member

bump

@yannickwurm
Copy link
Member

@augeas - could you please pull out the essentials from here?

@yannickwurm yannickwurm requested a review from augeas July 19, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants