Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide m2m applications in application selection modal in IDP quickstart #7234

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

pavinduLakshan
Copy link
Contributor

@pavinduLakshan pavinduLakshan commented Dec 22, 2024

Purpose

$subject

current filteredApplicationsList logic filters the system apps on the frontend before displaying the eligible application list in the application select wizard in IDP quickstart. However, this is now not necessary as there is BE support to retrieve the apps excluding system apps[1].

This PR modifies the frontend logic to filter out m2m applications as there is no BE support to filter apps based on the template type and utilizes the BE support to exclude system apps.

[1] #7002

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.32%. Comparing base (d776a6a) to head (bbb1d92).
Report is 224 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7234   +/-   ##
=======================================
  Coverage   32.32%   32.32%           
=======================================
  Files          42       42           
  Lines         897      897           
  Branches      217      221    +4     
=======================================
  Hits          290      290           
- Misses        557      607   +50     
+ Partials       50        0   -50     
Flag Coverage Δ
@wso2is/core 32.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@pavinduLakshan pavinduLakshan merged commit 42d025d into wso2:master Jan 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants