-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI to incorporate authentication flow with the external authentication service #7207
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7207 +/- ##
==========================================
+ Coverage 32.02% 36.04% +4.01%
==========================================
Files 41 42 +1
Lines 893 899 +6
Branches 204 222 +18
==========================================
+ Hits 286 324 +38
+ Misses 607 555 -52
- Partials 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
0086afa
to
9a1c599
Compare
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
80daea6
to
11a4b9a
Compare
* under the License. | ||
*/ | ||
|
||
.wizard-wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this class is not meant to be re-used.
If not, Better to scope with a specific class.
.custom-authentication-wizard {
.wizard-wrapper {
// rest
}
@@ -330,6 +335,24 @@ export const AuthenticatorCreateWizardFactory: FC<AuthenticatorCreateWizardFacto | |||
/> | |||
); | |||
|
|||
// TODO: use local for headings | |||
case "custom-authentication": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this id
coming from a Constant?
* Captures the properties of a externally implemented local authenticator. | ||
*/ | ||
export interface CustomAuthenticatorInterface extends StrictConnectionInterface { | ||
name?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all the attributes optional?
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Show resolved
Hide resolved
@@ -0,0 +1,978 @@ | |||
/** | |||
* Copyright (c) 2023-2024, WSO2 LLC. (https://www.wso2.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the license
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Show resolved
Hide resolved
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,3 @@ | |||
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the license header to new SVG files
Purpose
This PR onboard the UI related components associated with custom authentication feature.
Currently custom authentication creation is supported through
Create a New Connection
page.There are three custom authentication types which will be represented as three cards.
We have also introduced new icons with this feature.
Sub Tasks
As of now, we have completed UI components related to the create wizard and the following sub tasks are still in progress.
Authentication Type
step in the wizard.Related Issues
Related PRs (Needs to be merged before)
Design Discussions
Checklist
Security checks