Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle username existence and non-existence similarly #7010

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Yoshani
Copy link
Contributor

@Yoshani Yoshani commented Oct 21, 2024

Purpose

Add option to handle username existence and non-existence in the same way when account verification is enabled. The option Show username unavailability is added.

Related PRs

Related Issues

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@Yoshani Yoshani changed the title Handle username existence to prevent enumeration Handle username existence and non-existence similarly Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (90b52b9) to head (4b775a9).
Report is 123 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7010   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      204      204           
=======================================
  Hits          283      283           
  Misses        607      607           
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

brionmario
brionmario previously approved these changes Oct 21, 2024
@Yoshani
Copy link
Contributor Author

Yoshani commented Oct 22, 2024

UI:

image

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants