Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
brionmario committed Aug 30, 2021
1 parent 8e27d04 commit d7a27ce
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ to the repo.
- Accessibility support
- Using custom components
- Performance
- [UI design guidelines](https://github.com/wso2-enterprise/asgardeo-app-extensions/blob/master/docs/ui-design-guide.md)
- UI design guidelines - TODO
3 changes: 1 addition & 2 deletions apps/console/src/extensions/configs/scim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
import { SCIMConfigInterface } from "./models/scim";

/**
* This configuration is used to overwrite (in asgardeo-app-extension) and pass the,
* wso2 custom dialect to the Asgardeo.
* SCIM dialect configurations.
*/
export const SCIMConfigs: SCIMConfigInterface = {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export class ApplicationManagementConstants {
/**
* Currently refresh grant type is recommended to use atleast one of below.
* We need to get information from backend rather than hard code.
* This isssue is track via https://github.com/wso2-enterprise/asgardeo-product/issues/1852.
* This isssue is track via https://github.com/wso2/product-is/issues/12397.
*/
public static readonly IS_REFRESH_TOKEN_GRANT_TYPE_ALLOWED = [
ApplicationManagementConstants.AUTHORIZATION_CODE_GRANT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const DEFAULT_PROTOCOL_BINDING = "redirect";
* these methods simply does the mapping for us.
*
* This issue is currently tracking via:-
* FIXME: https://github.com/wso2-enterprise/asgardeo-product/issues/4288
* TODO: https://github.com/wso2/product-is/issues/12395
*/

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export const FacebookAuthenticationProviderCreateWizard: FunctionComponent<
];

// TODO: Refactor the usage of absolute image paths once Media Service is available.
// Tracked here - https://github.com/wso2-enterprise/asgardeo-product/issues/2973
// Tracked here - https://github.com/wso2/product-is/issues/12396
if (AppConstants.getClientOrigin()) {
if (AppConstants.getAppBasename()) {
identityProvider.image = AppConstants.getClientOrigin() +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export const GitHubAuthenticationProviderCreateWizard: FunctionComponent<
];

// TODO: Refactor the usage of absolute image paths once Media Service is available.
// Tracked here - https://github.com/wso2-enterprise/asgardeo-product/issues/2973
// Tracked here - https://github.com/wso2/product-is/issues/12396
if (AppConstants.getClientOrigin()) {
if (AppConstants.getAppBasename()) {
identityProvider.image = AppConstants.getClientOrigin() +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { SettingsSection } from "../../shared";
* Proptypes for the user sessions edit component.
* Also see {@link UserSessionsEdit.defaultProps}
*/
interface AsgardeoProfileWidgetProps extends TestableComponentInterface {
interface ProfileWidgetPropsInterface extends TestableComponentInterface {
userSource?: string;
}

Expand All @@ -43,7 +43,7 @@ interface AsgardeoProfileWidgetProps extends TestableComponentInterface {
*
* @return {ReactElement}
*/
export const ProfileWidget: FunctionComponent<AsgardeoProfileWidgetProps> = (
export const ProfileWidget: FunctionComponent<ProfileWidgetPropsInterface> = (
props
): ReactElement => {

Expand Down
3 changes: 1 addition & 2 deletions apps/myaccount/src/extensions/configs/scim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
import { SCIMConfigInterface } from "./models/scim";

/**
* This configuration is used to overwrite (in asgardeo-app-extension) and pass the,
* wso2 custom dialect to the Asgardeo.
* SCIM dialect configurations.
*/
export const SCIMConfigs: SCIMConfigInterface = {

Expand Down
4 changes: 2 additions & 2 deletions docs/STYLE-GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ conventions, code formatting styles, UI design guidelines, etc., are provided.
- Using custom components
- Performance
- [Developer guidelines](https://github.com/wso2/identity-apps/blob/master/docs/DEVELOPER.md)
- [UI design guidelines](https://github.com/wso2-enterprise/asgardeo-app-extensions/blob/master/docs/ui-design-guide.md)
- UI design guidelines - TODO


## Introduction
Expand All @@ -37,4 +37,4 @@ The @wso2is/form library that we use in the WSO2 Identity App portals cater to a
identified when it comes to its use-cases. This helps to govern the styles of the form elements, and the behavioral
patterns of the forms used in WSO2 Identity Apps. Follow [these guidelines](https://github.com/wso2/identity-apps/blob/master/docs/FORMS.md)
to implement a form in the Identity App portals more efficiently, maintaining consistency of the UI aspects as well as the
code base that are introduced in the Asgardeo forms.
code base.

0 comments on commit d7a27ce

Please sign in to comment.