Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scim user patch for migrating users #422

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

@amanda-ariyaratne amanda-ariyaratne commented Jan 31, 2025

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 58.62069% with 24 lines in your changes missing coverage. Please review.

Project coverage is 30.15%. Comparing base (29f0eb5) to head (9353458).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...3/core/protocol/endpoints/UserResourceManager.java 59.64% 17 Missing and 6 partials ⚠️
.../org/wso2/charon3/core/extensions/UserManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #422      +/-   ##
============================================
+ Coverage     30.03%   30.15%   +0.12%     
- Complexity      976      991      +15     
============================================
  Files           134      134              
  Lines         13145    13202      +57     
  Branches       2518     2534      +16     
============================================
+ Hits           3948     3981      +33     
- Misses         8702     8720      +18     
- Partials        495      501       +6     
Flag Coverage Δ
unit 29.42% <58.62%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13066868645

@amanda-ariyaratne amanda-ariyaratne changed the title Handle scim patch for migrating users Handle scim user patch for migrating users Jan 31, 2025
…ol/endpoints/UserResourceManager.java

Co-authored-by: Lashini Jayasekara <[email protected]>
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13066868645
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13068113400

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13068113400
Status: failure

@amanda-ariyaratne
Copy link
Contributor Author

The test failures have failed intermittently before. Will run the integration tests again with the version bump in the scim2-common component.

@amanda-ariyaratne amanda-ariyaratne merged commit e4812bc into wso2:master Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants