Improvement of tenant deletion #1882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruwanta
reviewed
Dec 4, 2018
| @@ -727,4 +729,21 @@ public boolean accept(File userStores, String name) { | |||
| private void clearTenantCache(int tenantId) { | |||
| tenantCacheManager.clearCacheEntry(new TenantIdKey(tenantId)); | |||
| } | |||
|
|
|||
| private void deleteCachemanager(String tenantDomain, int tenantId) { | |||
There was a problem hiding this comment.
better name would be "clearCacheManager" or "purgeCacheManager"
ruwanta
reviewed
Dec 4, 2018
|
|
||
| Caching.getCacheManagerFactory().close(); | ||
| } catch (Exception e) { | ||
| log.error("Unable to delete cache for tenant :"+tenantDomain); |
There was a problem hiding this comment.
log.error("Unable to delete cache for tenant :"+tenantDomain, e);
Prints the stacktrace upon error, so that finding root cause is easy.
ruwanta
reviewed
Dec 4, 2018
| } finally { | ||
| PrivilegedCarbonContext.endTenantFlow(); | ||
| } | ||
|
|
deleteCacheManager method name changed as clearCachemanager
Cleared empty lines
ruwanta
approved these changes
Dec 4, 2018
senthalan
reviewed
Dec 5, 2018
| * @param tenantDomain tenant domain | ||
| * @param tenantId tenant id | ||
| */ | ||
| private void clearCachemanager(String tenantDomain, int tenantId) { |
There was a problem hiding this comment.
naming has to be "clearCacheManager"
|
This is already fixed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we delete a tenant(with existing methods) we didn't delete the caches and the entry in globalCacheManagerMap. So when ever we try to create a new tenant with same domain name it checks with map and instead of creating new cache managers it returns existing entry value which owns by previous tenant. This cause the error mentioned in issue given below.
Goals
Fix for the Issue :- Security exception occurred when try to create a tenant with deleted tenant's domain name
Approach
While deleting a tenant delete
Documentation
Tenant Deletion Doc