Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize idp cloning #6538

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

Thisara-Welmilla
Copy link
Contributor

Origin issue:

Related PR:

Cloning is required because the endpointConfig of the federated authenticator config cannot be serialized. However, it can be skipped for local IDPs, as they do not have custom federated authenticators.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13418296177

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.22%. Comparing base (c03a9ac) to head (0544e8f).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
...internal/core/ApplicationAuthenticatorManager.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6538      +/-   ##
============================================
- Coverage     47.54%   47.22%   -0.32%     
+ Complexity    16399    15407     -992     
============================================
  Files          1910     1754     -156     
  Lines        110506   106123    -4383     
  Branches      20181    19711     -470     
============================================
- Hits          52535    50115    -2420     
+ Misses        50633    48915    -1718     
+ Partials       7338     7093     -245     
Flag Coverage Δ
unit 30.55% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13418296177
Status: failure

@malithie
Copy link
Member

https://github.com/wso2/product-is/actions/runs/13418296177

This test failure is due to
[INFO] Results: [INFO] [ERROR] Failures: [ERROR] UserSessionAdminSuccessTest.testConclude:96 NullPointer [ERROR] UserSessionAdminSuccessTest>UserSessionTest.testInitData:134->UserSessionTest.createServiceProvider:231 » Remote [INFO] [ERROR] Tests run: 3368, Failures: 2, Errors: 0, Skipped: 6

As this specific test has been failing intermittently we will ignore and merge the PR

@malithie malithie merged commit 40d3317 into wso2:master Feb 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants