Add CustomCXFNonSpringJaxrsServlet #6291
Open
+995
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lashinijay
force-pushed
the
master-custom-servlet
branch
from
25d0c0b to
eed9839
Compare
|
PR builder started |
|
PR builder completed |
nilasini
reviewed
Jan 17, 2025
nilasini
reviewed
Jan 17, 2025
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
nilasini
reviewed
Jan 17, 2025
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
nilasini
reviewed
Jan 17, 2025
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
nilasini
reviewed
Jan 17, 2025
| this.injectProperties(object, props); | ||
| list.add((Interceptor) object); | ||
| } catch (ServletException exception) { | ||
| throw exception; |
There was a problem hiding this comment.
why are we catching this exception? Since the method is already throwing the exception we don't need to catch it
…er-custom-servlet # Conflicts: # components/servlet-mgt/org.wso2.carbon.identity.servlet.mgt/pom.xml # components/servlet-mgt/org.wso2.carbon.identity.servlet.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java # components/servlet-mgt/pom.xml
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Related Issue(s)