-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SAML name ID format inconsistency #436
Fix SAML name ID format inconsistency #436
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
============================================
- Coverage 46.89% 46.86% -0.03%
Complexity 1343 1343
============================================
Files 116 116
Lines 9223 9226 +3
Branches 1090 1091 +1
============================================
- Hits 4325 4324 -1
- Misses 4294 4298 +4
Partials 604 604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8bf6a6d
to
4c5d03c
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12622470170
Unit tests are written to cover the changes done in this PR even though it is not identified by the codecov. |
From this fix, we fix the inconsistency in API response regarding the SAML name ID format.
Public Issue - wso2/product-is#21826