Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAML name ID format inconsistency #436

Merged

Conversation

SujanSanjula96
Copy link
Contributor

From this fix, we fix the inconsistency in API response regarding the SAML name ID format.

Public Issue - wso2/product-is#21826

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.86%. Comparing base (8ab8362) to head (4c5d03c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...on/identity/sso/saml/admin/SAMLSSOConfigAdmin.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #436      +/-   ##
============================================
- Coverage     46.89%   46.86%   -0.03%     
  Complexity     1343     1343              
============================================
  Files           116      116              
  Lines          9223     9226       +3     
  Branches       1090     1091       +1     
============================================
- Hits           4325     4324       -1     
- Misses         4294     4298       +4     
  Partials        604      604              
Flag Coverage Δ
unit 19.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12622470170

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12622470170
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12622470170

@SujanSanjula96
Copy link
Contributor Author

Unit tests are written to cover the changes done in this PR even though it is not identified by the codecov.

@SujanSanjula96 SujanSanjula96 merged commit cbbe1b1 into wso2-extensions:master Jan 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants