Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post consent not requested mandatory claims #2731

Merged

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Feb 21, 2025

Proposed changes in this pull request

Issue: wso2/product-is#23228
With this pull request(#2685), we introduce a fix to prevent requesting consent, even if the attribute is marked as mandatory in the application section.

While setting a claim as mandatory without including it as a scope is not an ideal approach, certain scenarios may require this due to legacy behavior. For those scenarios post consent methods is failing, so this fix address that issue by removing those not request attributes before sending to framework sso

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13465225731

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.33%. Comparing base (ba31964) to head (492907a).
Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
...tity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2731      +/-   ##
============================================
- Coverage     56.47%   56.33%   -0.14%     
- Complexity     8548     8716     +168     
============================================
  Files           654      654              
  Lines         48679    49988    +1309     
  Branches      10152    10560     +408     
============================================
+ Hits          27491    28161     +670     
- Misses        17274    17820     +546     
- Partials       3914     4007      +93     
Flag Coverage Δ
unit 39.97% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13465225731
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13465225731

@Thumimku Thumimku merged commit d043cac into wso2-extensions:master Feb 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants