Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the client ids missing in filtering. #2726

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Feb 20, 2025

Purpose

  • $subject

Description

Related issues

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13429197084

AnuradhaSK
AnuradhaSK previously approved these changes Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (f04d876) to head (45484e8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2726      +/-   ##
============================================
+ Coverage     56.25%   56.92%   +0.66%     
+ Complexity     8619     8570      -49     
============================================
  Files           654      654              
  Lines         49657    48442    -1215     
  Branches      10472    10263     -209     
============================================
- Hits          27934    27575     -359     
+ Misses        17726    16959     -767     
+ Partials       3997     3908      -89     
Flag Coverage Δ
unit 39.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnuradhaSK AnuradhaSK dismissed their stale review February 20, 2025 06:31

have a comment

@SujanSanjula96
Copy link
Contributor

SujanSanjula96 commented Feb 20, 2025

Since this is tested locally and no any associated integration tests, we can proceed without integration tests.

@SujanSanjula96
Copy link
Contributor

@Malith-19 Let's refactor this logic for better readability with your current effort.

@nilasini
Copy link
Contributor

@Malith-19 please cover unit test cases as well with your effort

@SujanSanjula96 SujanSanjula96 merged commit 2cc27a3 into wso2-extensions:master Feb 20, 2025
3 of 4 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13429197084
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants