Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Client Initiated Backchannel Authentication #2725

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shashimalcse
Copy link
Contributor

@shashimalcse shashimalcse commented Feb 18, 2025

Proposed changes in this pull request

$subject

Related Issues

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 21.00840% with 282 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (ea52b03) to head (60b0861).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...uth/ciba/handlers/CibaUserNotificationHandler.java 0.00% 137 Missing ⚠️
...auth/endpoint/ciba/UserAuthenticationEndpoint.java 49.15% 27 Missing and 3 partials ⚠️
...auth/ciba/internal/CibaServiceComponentHolder.java 0.00% 27 Missing ⚠️
...tity/oauth/ciba/internal/CibaServiceComponent.java 0.00% 21 Missing ⚠️
.../oauth/ciba/model/CibaUserNotificationContext.java 0.00% 20 Missing ⚠️
...entity/oauth/endpoint/ciba/OAuth2CibaEndpoint.java 76.59% 7 Missing and 4 partials ⚠️
...n/identity/oauth/ciba/api/CibaAuthServiceImpl.java 0.00% 8 Missing ⚠️
...ba/resolvers/impl/DefaultCibaUserResolverImpl.java 0.00% 8 Missing ⚠️
...y/oauth/ciba/handlers/CibaResponseTypeHandler.java 60.00% 4 Missing and 2 partials ⚠️
...arbon/identity/oauth/ciba/api/CibaAuthService.java 0.00% 3 Missing ⚠️
... and 5 more

❌ Your patch check has failed because the patch coverage (21.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2725      +/-   ##
============================================
- Coverage     56.60%   55.51%   -1.09%     
- Complexity     8526     8676     +150     
============================================
  Files           654      661       +7     
  Lines         48357    50272    +1915     
  Branches      10074    10541     +467     
============================================
+ Hits          27371    27911     +540     
- Misses        17096    18383    +1287     
- Partials       3890     3978      +88     
Flag Coverage Δ
unit 39.78% <21.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant