-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix roles retrieval in user info response for sub org and fragment apps. #2721
Fix roles retrieval in user info response for sub org and fragment apps. #2721
Conversation
03913b6
to
00a3577
Compare
PR builder started |
PR builder completed |
431fca6
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2721 +/- ##
============================================
- Coverage 56.61% 56.02% -0.60%
- Complexity 8537 8667 +130
============================================
Files 654 654
Lines 48417 49623 +1206
Branches 10111 10469 +358
============================================
+ Hits 27413 27802 +389
- Misses 17109 17838 +729
- Partials 3895 3983 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
431fca6
to
c3a7218
Compare
c3a7218
to
7a47c74
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13404761933
Proposed changes in this pull request
Currently when the user attribute are not cached, all the roles are returned in UserInfo response. When fixing this bug for root org apps, we need to consider backward compatibility. But for sub organization apps and shared apps, we can give the correct behaviour since,
Related Issue - wso2/product-is#22984