Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roles retrieval in user info response for sub org and fragment apps. #2721

Merged

Conversation

SujanSanjula96
Copy link
Contributor

Proposed changes in this pull request

Currently when the user attribute are not cached, all the roles are returned in UserInfo response. When fixing this bug for root org apps, we need to consider backward compatibility. But for sub organization apps and shared apps, we can give the correct behaviour since,

  • Userinfo endpoint can't be externally called for shared apps.
  • Sub organization apps are newly introduced feature which doesn't need backward compatibility.

Related Issue - wso2/product-is#22984

shashimalcse
shashimalcse previously approved these changes Feb 18, 2025
AnuradhaSK
AnuradhaSK previously approved these changes Feb 18, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13394646202

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13394646202
Status: failure

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (501cde5) to head (7a47c74).
Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
...carbon/identity/oauth/endpoint/util/ClaimUtil.java 60.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2721      +/-   ##
============================================
- Coverage     56.61%   56.02%   -0.60%     
- Complexity     8537     8667     +130     
============================================
  Files           654      654              
  Lines         48417    49623    +1206     
  Branches      10111    10469     +358     
============================================
+ Hits          27413    27802     +389     
- Misses        17109    17838     +729     
- Partials       3895     3983      +88     
Flag Coverage Δ
unit 39.96% <60.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13404761933

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13404761933
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13404761933

@SujanSanjula96 SujanSanjula96 merged commit 853f444 into wso2-extensions:master Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants