Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back-channel logout url for OIDC apps shared with organizations #2699

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

hwupathum
Copy link
Contributor

@hwupathum hwupathum commented Feb 7, 2025

Summary

This pull request adds back-channel logout URL for OIDC applications shared with sub-organizations to send a backchannel logout request to SSO application in the root org.

Related issue

wso2/product-is#22338

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.65%. Comparing base (c74491e) to head (6500022).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...org/wso2/carbon/identity/oauth/dao/OAuthAppDO.java 78.57% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2699      +/-   ##
============================================
+ Coverage     56.57%   56.65%   +0.07%     
- Complexity     8520     8546      +26     
============================================
  Files           654      654              
  Lines         48311    48390      +79     
  Branches       9657     9788     +131     
============================================
+ Hits          27332    27413      +81     
+ Misses        17098    17081      -17     
- Partials       3881     3896      +15     
Flag Coverage Δ
unit 39.76% <78.57%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13227329806

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13227329806
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13227329806

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13227329806
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13227329806

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13227329806
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13227329806

@hwupathum hwupathum merged commit 8c72498 into wso2-extensions:master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants