-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing application_type and response_type from DCR API model #2693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2693 +/- ##
============================================
+ Coverage 56.18% 56.31% +0.13%
+ Complexity 8636 8589 -47
============================================
Files 654 654
Lines 49129 49258 +129
Branches 9817 9917 +100
============================================
+ Hits 27601 27739 +138
+ Misses 17586 17570 -16
- Partials 3942 3949 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
Test failures are irrelevant to this fix. |
PR builder completed |
Failing with above 2 issues, and those are not related the this DCR fix. Hence merging this PR |
Proposed changes in this pull request
This PR remove application_type and response_type from DCR API model hence these parameters are not processed or stored in IS.
Related issue : wso2/product-is#21097
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation