Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user authorization check when accessing org is different from resident org #2652

Conversation

ShanChathusanda93
Copy link
Contributor

Proposed changes in this pull request

[1] https://github.com/wso2-extensions/identity-carbon-auth-rest/blob/9eb3d1380f3af32c35de98591dd2c5a5bb728026/components/org.wso2.carbon.identity.authz.service/src/main/java/org/wso2/carbon/identity/authz/service/handler/AuthorizationHandler.java#L109

When should this PR be merged

This PR needs to be merged before merging wso2-extensions/identity-carbon-auth-rest#299

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (e9a9049) to head (4b205a4).
Report is 122 commits behind head on master.

Files with missing lines Patch % Lines
...rg/wso2/carbon/identity/oauth2/util/AuthzUtil.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2652      +/-   ##
============================================
- Coverage     56.54%   56.36%   -0.19%     
- Complexity     8264     8265       +1     
============================================
  Files           632      632              
  Lines         46702    47301     +599     
  Branches       8482     8612     +130     
============================================
+ Hits          26406    26659     +253     
- Misses        16585    16857     +272     
- Partials       3711     3785      +74     
Flag Coverage Δ
unit 38.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12913420267

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12913420267
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12913420267

Copy link
Contributor

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit test as soon as possible. @ShanChathusanda93

@ShanChathusanda93 ShanChathusanda93 merged commit f4caedd into wso2-extensions:master Jan 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants