Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes grants from String to ArrayList #2136

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

Kirishikesan
Copy link
Contributor

@Kirishikesan Kirishikesan commented Aug 17, 2023

Overview

The pack was storing the grants in String data type with spaces as delimiters and querying the grants. Even when the grant types which are present as substrings, it was detected as present. This PR stores grants as an ArrayList instead of String

Resolves :

wso2/api-manager#2094

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

@Kirishikesan Kirishikesan requested a review from nilasini August 17, 2023 16:17
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5898981183

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5898981183
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5899153567

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5899153567
Status: failure

@nilasini
Copy link
Contributor

Since the failure is not related with this PR, merging this PR.

[ERROR] org.wso2.identity.integration.test.sts.TestPassiveSTS.testPassiveSAML2Assertion(org.wso2.identity.integration.test.sts.TestPassiveSTS)
 [ERROR] Run 1: TestPassiveSTS.testPassiveSAML2Assertion:268 No SAML2 Assertion found for the SAML2 request for tenant domain: carbon.super expected:<true> but was:<false>
 [INFO] Run 2: PASS
 [INFO] 
 [ERROR] org.wso2.identity.integration.test.sts.TestPassiveSTS.testPassiveSAML2AssertionForInvalidWReply(org.wso2.identity.integration.test.sts.TestPassiveSTS)
 [ERROR] Run 1: TestPassiveSTS.testPassiveSAML2AssertionForInvalidWReply:319 Cannot find soap fault for invalid WReply URL for tenant domain: carbon.super expected:<true> but was:<false>
 [INFO] Run 2: PASS
 [INFO] 
 [ERROR] org.wso2.identity.integration.test.sts.TestPassiveSTS.testPassiveSAML2AssertionWithoutWReply(org.wso2.identity.integration.test.sts.TestPassiveSTS)
 [ERROR] Run 1: TestPassiveSTS.testPassiveSAML2AssertionWithoutWReply:292 No SAML2 Assertion found for the SAML2 request without WReply in passive-sts request for tenant domain: carbon.super expected:<true> but was:<false>
 [INFO] Run 2: PASS
 [INFO] 
 [INFO] 
 [ERROR] Tests run: 1994, Failures: 3, Errors: 0, Skipped: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants