-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python from 3.8 to 3.9 #2271
base: main
Are you sure you want to change the base?
Update Python from 3.8 to 3.9 #2271
Conversation
8742f13
to
c883d89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here!
If we're doing this work, I wonder if it makes sense to upgrade to 3.10 or 3.11, so we're a bit closer to the latest version? Might cause more cascading dependency upgrades though.
aac51c3
to
28f481a
Compare
28f481a
to
70150f9
Compare
I took a quick look at the two broken links, and they seem pretty irrelevant to this PR, which does make me wonder why they aren't failing the main build:
|
Yeah i'm seeing this as well. I was trying different pip modules/package versions to tackle this. No solution yet.. Maybe there are indeed wrong links? |
Yeah it's probably a difference in behaviour from the HTML output? This ugliness is L75: <div class="breadcrumbs">
<a href="../../../../">Home</a> »
</div> The href here is L140: <p class="logo">
<a href="../../../../">
<img class="logo" src="../../../../_static/sticker-wtd-colors.png" alt="Logo" />
</a>
</p> Could track down where it's generated, and if there isn't an obvious fix, just ignore it? :-p https://github.com/gjtorikian/html-proofer?tab=readme-ov-file#ignoring-content |
a31d705
to
5aa6f09
Compare
If we want to make this pass I'm happy to exclude |
Thanks for understanding! Let me look into it one more time, maybe i can come up with a fix. Otherwise let's ignore it. |
I wonder if diffing the ablog source between the versions would help? I don't think we've got custom ablog templates in our repo. |
What
How to test
📚 Documentation preview 📚: https://writethedocs-www--2271.org.readthedocs.build/