Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python from 3.8 to 3.9 #2271

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nickspaargaren
Copy link
Contributor

@nickspaargaren nickspaargaren commented Dec 18, 2024

What

How to test

  • Follow the "Installing the project" instructions.
  • Make sure the projects runs on Python 3.9
  • Check out the Python 3.9 deprecated section for breaking changes
  • All GitHub Actions (pipelines) should pass

📚 Documentation preview 📚: https://writethedocs-www--2271.org.readthedocs.build/

@nickspaargaren nickspaargaren force-pushed the update-python-from-3-8-to-3-9 branch 3 times, most recently from 8742f13 to c883d89 Compare December 18, 2024 22:32
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here!

If we're doing this work, I wonder if it makes sense to upgrade to 3.10 or 3.11, so we're a bit closer to the latest version? Might cause more cascading dependency upgrades though.

requirements.txt Outdated Show resolved Hide resolved
@nickspaargaren nickspaargaren force-pushed the update-python-from-3-8-to-3-9 branch 3 times, most recently from aac51c3 to 28f481a Compare December 20, 2024 16:34
@nickspaargaren nickspaargaren force-pushed the update-python-from-3-8-to-3-9 branch from 28f481a to 70150f9 Compare December 22, 2024 11:20
@plaindocs
Copy link
Contributor

plaindocs commented Dec 22, 2024

I took a quick look at the two broken links, and they seem pretty irrelevant to this PR, which does make me wonder why they aren't failing the main build:

 For the Links > Internal check, the following failures were found:

* At docs/_build/html/blog/archive/tag/index.html:75:

  internally linking to ../../../../, which does not exist

* At docs/_build/html/blog/archive/tag/index.html:140:

  internally linking to ../../../../, which does not exist

@nickspaargaren
Copy link
Contributor Author

I took a quick look at the two broken links, and they seem pretty irrelevant to this PR, which does make me wonder why they aren't failing the main build:


 For the Links > Internal check, the following failures were found:



* At docs/_build/html/blog/archive/tag/index.html:75:



  internally linking to ../../../../, which does not exist



* At docs/_build/html/blog/archive/tag/index.html:140:



  internally linking to ../../../../, which does not exist

Yeah i'm seeing this as well. I was trying different pip modules/package versions to tackle this. No solution yet.. Maybe there are indeed wrong links?

@plaindocs
Copy link
Contributor

Yeah it's probably a difference in behaviour from the HTML output?

This ugliness is L75:

          <div class="breadcrumbs">
            
            
              <a href="../../../../">Home</a> &raquo;
                
            
          </div>

The href here is L140:

<p class="logo">
  <a href="../../../../">
    <img class="logo" src="../../../../_static/sticker-wtd-colors.png" alt="Logo" />
    
  </a>
</p>

Could track down where it's generated, and if there isn't an obvious fix, just ignore it? :-p

https://github.com/gjtorikian/html-proofer?tab=readme-ov-file#ignoring-content

@nickspaargaren nickspaargaren force-pushed the update-python-from-3-8-to-3-9 branch from a31d705 to 5aa6f09 Compare December 27, 2024 09:23
@plaindocs
Copy link
Contributor

If we want to make this pass I'm happy to exclude docs/_build/html/blog/archive/tag/index.html manually in the htmlproofer call in CI and add an issue to look into it at another date.

@nickspaargaren
Copy link
Contributor Author

If we want to make this pass I'm happy to exclude docs/_build/html/blog/archive/tag/index.html manually in the htmlproofer call in CI and add an issue to look into it at another date.

Thanks for understanding! Let me look into it one more time, maybe i can come up with a fix. Otherwise let's ignore it.

@plaindocs
Copy link
Contributor

I wonder if diffing the ablog source between the versions would help? I don't think we've got custom ablog templates in our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants