Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD updates #2240

Merged
merged 2 commits into from
Oct 7, 2024
Merged

RTD updates #2240

merged 2 commits into from
Oct 7, 2024

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Oct 7, 2024

@plaindocs plaindocs requested a review from mxsasha October 7, 2024 11:03
@plaindocs
Copy link
Contributor Author

There is also config in the GH settings for that, so let's make sure that's the issue before committing ?

@mxsasha
Copy link
Contributor

mxsasha commented Oct 7, 2024

There is also config in the GH settings for that, so let's make sure that's the issue before committing ?

Don't think it is on closer look. I think we're missing https:// prefix - trying that now. Might cause issues with PR builds and link checks though, as links won't be available on www.writethedocs.org and maybe there will be misdirected absolute URLs, that should have the PR URL instead. But I do want to get the recap out, so if this fixes that part, it'll have to do for now.

@plaindocs
Copy link
Contributor Author

The content looks ok, so it might be just the linkchecker config

I'd rather disable that temporarily than revert the CI

@mxsasha
Copy link
Contributor

mxsasha commented Oct 7, 2024

The content looks ok, so it might be just the linkchecker config

Revert is already dropped, see other comment :)

@mxsasha mxsasha merged commit 4ff23f5 into main Oct 7, 2024
7 checks passed
@mxsasha mxsasha deleted the sam-rtd-update branch October 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants