-
Notifications
You must be signed in to change notification settings - Fork 515
Fixes encoding error when building under Windows #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good morning, Kevin! ( @kdschlosser ) cc: @plaindocs Okay, the YAML intake APPEARS nicely handled. (I am assuming that all the YAML stuff is read in before the .RST files are read.) What I know for sure is that Sphinx is starting without errors and getting 31% into the reading phase before hitting the "next thing". Sam, I can attest this is safe to merge. The change only impacts those on the Windows platform, and it is certainly an improvement. Are you acquainted with rebasing (it's a bit cleaner than merging
That will handle the conflict and re-trigger the checks. |
@plaindocs Over to you, sir.... I can confirm that without the above code, the build only gets 14% of the way through and then generates this error:
And WITH the new code, it gets 31% of the way through the build (i.e. past the above error) and stops due to a different reason, which I am hoping to solve next (possibly with Kevin's help). Kind regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this folks! This looks fine to me.
If we can get things working it looks like I might be able to add a Windows GitHub action build which will help keep it running.
@kdschlosser Hi, Kevin. Sam approved auto-merge, so it will happen as soon as the "out-of-date" situation is handled. |
onto the next bump in the road.... we will get it up and running no worries there... I can write the CI for Windows as well if ya want... |
You're a star. I think #2226 mostly does the thing, but if there is anything to improve please point it out. |
I'll take a look at the code for #2226 and see if there is anything that needs to be done with it. Github actions is really easy to use and you don't have an overly complex build system or crazy amounts of build requirements so it should be fairly straight forward to add the Windows build to the CI. |
@vwheeler63
Here is the second go. Lets get this one tested and merged and then we can address other issues in another PR
📚 Documentation preview 📚: https://writethedocs-www--2222.org.readthedocs.build/