Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 2024 site #2051

Merged
merged 12 commits into from
Nov 16, 2023
Merged

Ship 2024 site #2051

merged 12 commits into from
Nov 16, 2023

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 9, 2023

This is a WIP preview to get PR previews


📚 Documentation preview 📚: https://writethedocs-www--2051.org.readthedocs.build/conf/portland/2024/

@plaindocs
Copy link
Contributor

Looking at this PR, can we replace the "has sponsors" flag with check for content in the sponsors file? Or not worth the trouble CC @mxsasha

Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and questions

@@ -107,23 +107,23 @@ date: # how do we handle these? human readable would be nice.

# Conference is special for the index to show the combined conference days
conference:
event: Main Conference
event: Speaker talks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not roll of the tongue. How about?

Suggested change
event: Speaker talks
event: Scheduled talks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I didn't know a great way to frame it. I was thinking something like Speaker presentations? Scheduled is not super valuable to include.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Programmed talks? Or even just Schedule?

date: April 15-16
summary: The main days of the conference. We will be running one main track of talks, as well as a <a href="/conf/portland/2024/job-fair/">Sponsor Expo</a>, <a href="/conf/portland/2024/lightning-talks/">Lightning Talks</a> & <a href="/conf/portland/2024/unconference/">Unconference</a>.
summary: The main days of the conference. Listen to a diverse panel of speakers share their insights and experience. Currently accepting Call for Proposals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: The main days of the conference. Listen to a diverse panel of speakers share their insights and experience. Currently accepting Call for Proposals.
summary: The main days of the conference. Our speakers share their insights and experience, Other events include unconference discussions, lighting talks and job fair.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy from Katie, I think she wanted this stuff to change across time, which is definitely a bigger lift, but probably useful? 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but unless we're systematic about it, we're gonna drop stuff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just leave it off, and ditch most of my edits here as well as we're adding further stuff below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we could just wrap this in the conditional, although it's some pretty hairy nesting of syntax... :-D

docs/_templates/2024/index.html Show resolved Hide resolved
docs/_templates/2024/index.html Outdated Show resolved Hide resolved
@@ -275,3 +275,4 @@ flaghasboat: False
flaghaswritingday: True
flaghasjobfair: True
flaghasbadgeflair: True
flaghaslightningtalks: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, need to add it. Katie suggested adding all the events to the front page, which I think is a 💯 idea, and done here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanding the front page with more icons looks great, though I suspect the new additions need redesigning, but we don't need to block.

@ericholscher
Copy link
Member Author

@plaindocs Updated this to not ship the full menu, so we can port ship the front page changes now.

@mxsasha
Copy link
Contributor

mxsasha commented Nov 15, 2023

Looking at this PR, can we replace the "has sponsors" flag with check for content in the sponsors file? Or not worth the trouble CC @mxsasha

Yeah I think we can definitely do this. Let's not block this PR on it though.

Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah go for it, no blockers from me.

@ericholscher ericholscher merged commit e4f3c65 into main Nov 16, 2023
6 checks passed
@ericholscher ericholscher deleted the pdx-24-site branch November 16, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants