Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for local testing of tile cache server #194

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

danscales
Copy link
Contributor

I mainly updated the README instructions with a few things:

  • change gfw-staging to {bastion_server}
  • make it clear that PLANET_API_KEY must be set
  • mention you can get the password, keys, etc. from AWS secrets manager
  • give special instructions for Linux hosts

For linux hosts, the docker ports are only forwarded correctly to the host if you change the ports config
from just '8088:80' to '127.0.0.1:8088:80'

I mainly updated the README instructions with a few things:
  - change gfw-staging to {bastion_server}
  - make it clear that PLANET_API_KEY must be set
  - mention you can get the password, keys, etc. from
    AWS secrets manager
  - give special instructions for Linux hosts

For linux hosts, the docker ports are forward correctly to the host if
you change the ports config from just '8088:80' to '127.0.0.1:8088:80'
Copy link
Member

@solomon-negusse solomon-negusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated
the docker and gotten hung accessing the database. You can then start the docker by
hand via:

```docker run -it -p127.0.0.1:8088:80 --entrypoint /bin/bash gfw-tile-cache_app:latest```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space here -p127.0.0.1:8088:80

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works without the space as well, but putting in the space is more standard, so did that change.

@solomon-negusse
Copy link
Member

@danscales: It'd be good to add that for the ssh tunnel to work, the ip address should be whitelisted for port 22 access in the security groups. Thanks.

From Solomon's comments, added text that for the ssh tunnel to work,
your host's ip address should be whitelisted for port 22 in the
core-default security group.
@danscales
Copy link
Contributor Author

@danscales: It'd be good to add that for the ssh tunnel to work, the ip address should be whitelisted for port 22 access in the security groups. Thanks.

Good suggestion, done!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (98774c3) to head (04b9518).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #194   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files          61       61           
  Lines        2051     2051           
=======================================
  Hits         1638     1638           
  Misses        413      413           
Flag Coverage Δ
unittests 79.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants