Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fixes WP GraphQL fatal deactivation error #355

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

colinmurphy
Copy link
Contributor

@colinmurphy colinmurphy commented Feb 26, 2025

Solves #350 and #353

Overview

  • Fixes a bug with WPGraphQL Content Blocks causing a fatal error when WPGraphQL is de-activated. The plugin now requires WPGraphQL
  • Added plugin info for WPGraphQL. Tested to 2.0 and requires at least 1.14.5 (same as composer lock file)

Tests

Installed WPGraphQL 2.0 on WP 6.7.2 with Local

  1. Couldn't enable WPGraphQL Content Blocks until WPGraphQL was enabled
  2. WPGraphQL plugin couldn't be disabled when WPGraphQL Content Blocks was activated too

Screenshots

Screenshot 2025-02-26 at 17 39 05 Screenshot 2025-02-26 at 17 39 16 Screenshot 2025-02-26 at 17 39 30

Updated semver plugin to version 3

Added wp-graphql as a required plugin to ensure you cannot enable the plguin without WPGraphQL enabled.
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: fdb9589

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colinmurphy colinmurphy marked this pull request as ready for review February 26, 2025 17:50
@colinmurphy colinmurphy requested a review from a team as a code owner February 26, 2025 17:50
@colinmurphy
Copy link
Contributor Author

@justlevine @theodesp FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant