Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributing guide #114

Merged
merged 8 commits into from
Mar 27, 2025
Merged

docs: add contributing guide #114

merged 8 commits into from
Mar 27, 2025

Conversation

ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Mar 25, 2025

This PR adds contribution guide to hwptoolkit.

Related to #95

Subheadings:

  • Resources
  • Types of contribution
    • Report a bug or suggest a feature
    • Help other people and engage with community
    • Triage issues
    • Pull Requests (PR)
      • Project structure
      • Writing documentation
      • Conventional Commits
      • Steps to contribute
    • Discussions

@ahuseyn ahuseyn requested a review from a team as a code owner March 25, 2025 11:13
@ahuseyn ahuseyn mentioned this pull request Mar 25, 2025
Closed
colinmurphy
colinmurphy previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

moonmeister
moonmeister requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple layout and logistical things. Have we added changesets to this repo? Should we?

moonmeister
moonmeister reviewed Mar 26, 2025
View reviewed changes
@ahuseyn @moonmeister
Update CONTRIBUTING.md
b732345 
Co-authored-by: Alex Moon <[email protected]>
ahuseyn and others added 5 commits March 27, 2025 14:19
@ahuseyn @moonmeister
Update CONTRIBUTING.md
f0f8c7f 
Co-authored-by: Alex Moon <[email protected]>
@ahuseyn @moonmeister
Update CONTRIBUTING.md
d9d6e31 
Co-authored-by: Alex Moon <[email protected]>
@ahuseyn @moonmeister
Update CONTRIBUTING.md
ebf12f4 
Co-authored-by: Alex Moon <[email protected]>
@ahuseyn @moonmeister
Update CONTRIBUTING.md
509ae0c 
Co-authored-by: Alex Moon <[email protected]>
@ahuseyn @moonmeister
Update CONTRIBUTING.md
d3c1dcd 
Co-authored-by: Alex Moon <[email protected]>
@ahuseyn
Copy link
Member Author

ahuseyn commented Mar 27, 2025

Thanks @moonmeister, I've committed your suggestions except the email issue. I don't think we have changeset in this repo. We can discuss pros/const at this stage with the @wpengine/headless-open-source.

moonmeister
moonmeister previously approved these changes Mar 27, 2025
View reviewed changes
@moonmeister moonmeister requested a review from colinmurphy March 27, 2025 16:40
colinmurphy
colinmurphy requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuseyn @moonmeister

LGTM 🚀

I have added some small suggestion to add code of conduct (not merged but awaiting on one review)

@ahuseyn @colinmurphy
Update CONTRIBUTING.md
72d98a6 
Co-authored-by: Colin Murphy <[email protected]>
colinmurphy
colinmurphy approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@ahuseyn ahuseyn added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 98bf185 Mar 27, 2025
1 check passed
@ahuseyn ahuseyn deleted the add-contributing-guide branch March 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmurphy colinmurphy colinmurphy approved these changes

@moonmeister moonmeister moonmeister approved these changes

@theodesp theodesp Awaiting requested review from theodesp

@josephfusco josephfusco Awaiting requested review from josephfusco

@whoami-pwd whoami-pwd Awaiting requested review from whoami-pwd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuseyn @colinmurphy @moonmeister