docs: add routing guide #100
Conversation
There was a problem hiding this comment.
This is a preliminary review.
This is a good start that covers some practical issues at template hierarchy routing but doesn't address any routing options out of that. While example code is acceptable in explanation this also seems to stray into how to implement template hierarchy in nextjs.
It also never addresses routing issues unique to WP. Not explicitly.
Come Monday we can talk through more specifics I just wanted to get some initial thoughts out there. I can also detail things I think should be included.
|
I've got lots of thoughts on this one, @theodesp. You've got lots of great info, so I think I'll take some time to add more information and do some shaping. I almost took this myself but I think together it'll be even better. |
@moonmeister sure go ahead you can include your additions |
|
What is the state for this PR? |
Still working on it. |
|
@theodesp and @colinmurphy This is ready for another review. |
|
@moonmeister @theodesp LGTM 🚀 I added a few suggestions to the PR 👍 |
|
@colinmurphy I don't see any comments/suggestions |
Odd. See attached. @theodesp Do you see these? 
|
That says pending, you haven't submitted the review |
Ah sorry @moonmeister I forgot to click the request changes button. Requested changes now |
Co-authored-by: Colin Murphy <[email protected]>
Co-authored-by: Colin Murphy <[email protected]>
Description
#41