Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: term_link filter #1653

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

jasonbahl
Copy link
Contributor

Description

This fixes the term_link filter callback to not modify the term link urls for GraphQL requests.

Related Issue(s):

fixes: #1613

replaces: #1616

Testing

BEFORE:

Term uri is absolute in the GraphQL Response

CleanShot 2023-10-18 at 12 51 51

AFTER:

The term uri is relative in the GraphQL response

CleanShot 2023-10-18 at 12 53 00

But in the admin UIs the term links are absolute with the alternate Faust front-end domain.

CleanShot 2023-10-18 at 12 53 20

@jasonbahl jasonbahl self-assigned this Nov 14, 2023
@jasonbahl jasonbahl requested a review from a team as a code owner November 14, 2023 16:57

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: 0835df8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jasonbahl jasonbahl mentioned this pull request Nov 14, 2023
@josephfusco josephfusco added the package: faustwp Related to the companion WordPress plugin label Nov 16, 2023
@josephfusco josephfusco requested a review from mindctrl January 8, 2024 19:43
Copy link
Member

@theodesp theodesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mindctrl mindctrl merged commit 0aa1989 into wpengine:canary Jan 10, 2024
14 of 18 checks passed

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

mindctrl added a commit that referenced this pull request Jan 10, 2024
mindctrl added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: faustwp Related to the companion WordPress plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: nodeByUri return null in category page
4 participants