Fix CPT URL Rewrites

[dana-blackbean]

Tasks

• I have signed a Contributor License Agreement (CLA) with WP Engine.
• If a code change, I have written testing instructions that the whole team & outside contributors can understand.
• I have written and included a comprehensive changeset to properly document the changes I've made.

Description

When the option "Enable Post and Category URL rewrites" is turned on currently there is no check for any custom post types. This feature will currently only work on the default pages & posts.

Testing

1. Create a custom post type using ACF or similar that is public (Visible on the frontend and in the admin dashboard.)
2. Ensure the Faust option "Enable Post and Category URL rewrites" is enabled
3. From the canary branch, create a new post in that custom post type.
4. Once created, inspect the "view" link in the post list. This should match the WordPress URL
   
5. Now, checkout this PR
6. Visit the same custom post type list again, and notice the view link is now using the headless site url
   

[headless-platform-by-wp-engine]

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7a33ef2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@faustwp/wordpress-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[theodesp]

Hey @dana-blackbean thank you for the PR. Could you also provide a unit test for this filter?

You need to add test case to verify that the filter exists in the following file:

faustjs/plugins/faustwp/tests/integration/ReplacementCallbacksTests.php

Line 50 in 9a84eb4

[dana-blackbean]

@theodesp added!

[mindctrl]

@dana-blackbean thank you for this PR and apologies for the delay. We'll get this merged soon.

[mindctrl]

@dana-blackbean could you bring this up to date with canary? I tried but it wouldn't let me for some reason. Not sure if you're allowing edits from maintainers or if it's something else.

[dana-blackbean]

@mindctrl I am also running into the same issue with merging with canary. I was able to merge with the upstream/canary. I have also checked "allowing edits from maintainers". It was never disabled so not sure why you were weren't able to make changes.

[blakewilson]

We can ignore the Next.js Bundle Analysis / analyze workflow failure. This will fail from any PR contributor outside of the GitHub team.

[headless-platform-by-wp-engine]

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

[mindctrl]

Thank you @dana-blackbean! This will be in our next release.

[blakewilson]

@dana-blackbean This just landed in [email protected]. Thank you for your contribution!

[dana-blackbean]

@blakewilson @mindctrl Thank you both!!