Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR comments #1460

Merged
merged 9 commits into from
Jun 14, 2023
Merged

Fix PR comments #1460

merged 9 commits into from
Jun 14, 2023

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Jun 13, 2023

Tasks

Description

This PR fixes duplicate comments from the next.js bundle analysis action.

Screenshot 2023-06-13 at 3 52 06 PM

You can see from this image the action no longer creates a comment if one already exists

I also opened an issue in the action repo for other users running into this:
hashicorp/nextjs-bundle-analysis#68

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner June 13, 2023 20:34
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: ecbd087

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 83.65% 921/1101
🟡 Branches 68.32% 524/767
🟢 Functions 81.6% 133/163
🟢 Lines 83.24% 874/1050

Test suite run success

121 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 251576b

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-fix-multiple-pr-comments https://hl…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Coverage report for packages/faustwp-core

St.
Category Percentage Covered / Total
🟢 Statements 83.56% 849/1016
🟡 Branches 68.53% 516/753
🟢 Functions 84.4% 119/141
🟢 Lines 83.21% 818/983

Test suite run success

121 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from ecbd087

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Coverage report for packages/faustwp-cli

St.
Category Percentage Covered / Total
🟢 Statements 84.71% 72/85
🔴 Branches 57.14% 8/14
🟡 Functions 63.64% 14/22
🟢 Lines 83.58% 56/67

Test suite run success

15 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from ecbd087

@blakewilson blakewilson merged commit 444ab1d into canary Jun 14, 2023
@blakewilson blakewilson deleted the fix-multiple-pr-comments branch June 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants