VIP linter fixes #820
Open
VIP linter fixes #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldenapples
reviewed
Dec 5, 2019
goldenapples
approved these changes
Dec 5, 2019
|
@goldenapples Yes you are correct I thought it would be impossible to get rid of the one remaining warning but the code as it stands doesn't raise any linter issues. Would you mind reviewing? Thanks :) |
goldenapples
reviewed
Dec 9, 2019
| @@ -94,6 +94,12 @@ public function action_wp_ajax_shortcode_ui_post_field() { | |||
| $requested_shortcode = isset( $_GET['shortcode'] ) ? sanitize_text_field( $_GET['shortcode'] ) : null; | |||
| $requested_attr = isset( $_GET['attr'] ) ? sanitize_text_field( $_GET['attr'] ) : null; | |||
|
|
|||
| $include = filter_input( INPUT_GET, 'include', FILTER_SANITIZE_NUMBER_INT, FILTER_REQUIRE_ARRAY ); | |||
There was a problem hiding this comment.
I'm not sure I'm following what FILTER_SANITIZE_NUMBER_INT is doing here, since you map intval over the array a couple lines below. Is the sanitize_int filter just necessary to pass the lint rule?
There was a problem hiding this comment.
Yes this seems like an overzealous linter change really, will revisit this PR and see if it's still relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of issues were highlighted by the wp linter bot.
Sanitizes unsafe $_GET['include'] use and defines $args as an empty array before using it.
Tested against
?include=12,23a,?include[]=12&include[]=23aand without parameter.