Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline editor experiment #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

inline editor experiment #391

wants to merge 2 commits into from
+983 −417

Conversation

mattheu
Copy link
Contributor

@mattheu mattheu commented Jul 20, 2015

Experimental... do not merge.

I've been looking into the plausability of inline editing.

  1. Requires providing a completely custom view for the whole form, not just single fields.
    • This would probably be nice to have anyway.
  2. Requires a core patch to allow you to set the content of an MCE view as a jQuery object. This allows all the events defined in the view to work. Get it here
  3. NOT WORKING - saving. Not sure how to do this... using send_to_editor will refresh the MCE view and disrupt your editing experience.

Thoughts on 3.
You can probably work around and handle updating the content on save. I did get something working but it rendered the shortcode twice. This could also cause issues with multiple editors...

@khromov
Copy link
Contributor

khromov commented Sep 17, 2015

Very nice initiative. Inline editing would make this an amazing experience for content editors. 👍

@mattheu mattheu removed their assignment Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattheu @khromov