This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Use Instagram API oEmbed endpoint to get embed HTML #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why |
|
Okay, I have a cached implementation ready for review. It uses |
|
With 9fe321e, |
added 3 commits
December 11, 2015 13:47
The URL used in some of the tests would not resolve. I copied the ID of one of the working URLs used in another test and replaced the broken ones.
montchr
changed the title
| */ | ||
| protected static function get_oembed_html( $url, $args = array() ) { | ||
| global $post; | ||
| $post_id = $post->ID; |
There was a problem hiding this comment.
Looks like the global $post isn't working in unit tests. Any suggestions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#162
Based on the approach utilized by Jetpack.
TODO
hidecaptionattribute