-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for rocket head ordering #7304
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
created a followup issue here: |
Description
Fixes #7272
Every thing is mentioned in the issue itself.
Type of change
Detailed scenario
Here we refactor how our features add items into the head directly after title closing tag
</title>
.Technical description
Documentation
We introduced here a filter to print anything needed in the head part and its usage is as follows:
and this
$items
is an array of array variable with the following structure:and if u need to add HTML attribute without value, something like
crossorigin
, you can add its key as a numeric, something like:Also we introduced a helper trait called ElementTrait to help in inserting the common head elements like preload, preconnect, style, noscript, ...etc.
Also as a standard, we will use the following filter priorities:
New dependencies
No
Risks
We validated the e2e and it works, also most of tests passed, just had an issue with one test that it fails for the first time, that we need to revisit later on.
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks