-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7240: 3.19 - Beacon Insertion #7302
base: feature/7242-preload-fonts-data-insertion
Are you sure you want to change the base?
Closes #7240: 3.19 - Beacon Insertion #7302
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Description
Fixes #7240
Adds the beacon insertion to the page when no data is available in the db.
Type of change
Detailed scenario
Refer to issue
Technical description
Documentation
Service Provider Addition:
Added preload_fonts_factory to the list of performance hints in ServiceProvider.php.
Registered the preload_fonts_factory in the register method of ServiceProvider.php.
Created a new ServiceProvider class for the preload fonts feature in PreloadFonts/ServiceProvider.php.
Context Implementation:
Added a new Context class implementing ContextInterface to manage the context for preload fonts in PreloadFonts/Context/Context.php.
Factory Setup:
Introduced a Factory class implementing FactoryInterface to handle the creation of preload fonts-related objects in PreloadFonts/Factory.php.
Frontend Controller:
Added a Controller class implementing ControllerInterface to manage frontend optimizations for preload fonts in PreloadFonts/Frontend/Controller.php.
None
Risks
None
Mandatory Checklist
Code validation
Code style