Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7240: 3.19 - Beacon Insertion #7302

Open
wants to merge 17 commits into
base: feature/7242-preload-fonts-data-insertion
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Feb 12, 2025

Description

Fixes #7240
Adds the beacon insertion to the page when no data is available in the db.

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

Refer to issue

Technical description

Documentation

Service Provider Addition:

Added preload_fonts_factory to the list of performance hints in ServiceProvider.php.
Registered the preload_fonts_factory in the register method of ServiceProvider.php.
Created a new ServiceProvider class for the preload fonts feature in PreloadFonts/ServiceProvider.php.
Context Implementation:

Added a new Context class implementing ContextInterface to manage the context for preload fonts in PreloadFonts/Context/Context.php.
Factory Setup:

Introduced a Factory class implementing FactoryInterface to handle the creation of preload fonts-related objects in PreloadFonts/Factory.php.
Frontend Controller:

Added a Controller class implementing ControllerInterface to manage frontend optimizations for preload fonts in PreloadFonts/Frontend/Controller.php.
None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld requested a review from a team February 12, 2025 01:34
@Miraeld Miraeld self-assigned this Feb 12, 2025
@Miraeld Miraeld linked an issue Feb 12, 2025 that may be closed by this pull request
Copy link

codacy-production bot commented Feb 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.27% (target: -0.10%) 58.46% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e78c0e0) 38888 17199 44.23%
Head commit (cb7b9f2) 39257 (+369) 17258 (+59) 43.96% (-0.27%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7302) 65 38 58.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal linked an issue Feb 13, 2025 that may be closed by this pull request
@wordpressfan wordpressfan changed the base branch from feature/preload-fonts to feature/7242-preload-fonts-data-insertion February 14, 2025 14:43
@Miraeld Miraeld requested review from remyperona and a team February 17, 2025 00:47
@Miraeld Miraeld requested a review from jeawhanlee February 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.19 - Preload Fonts - Beacon insertion part
4 participants