Clean our RUCSS action scheduler jobs periodically without affecting others

[engahmeds3ed]

Description

We needed a way to clean our RUCSS action scheduler jobs after 1 hour without affecting the other jobs from other plugins.
Also added a new filter rocket_action_scheduler_retention_period so we can manage the clean lifespan for ours only.

Fixes #4940

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which improves an existing functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Checklist:

Please delete the options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Mai-Saad]

Working as expected
testrail-report-375.pdf

[engahmeds3ed]

We also added a new filter here to change the cleaner batch size (default value now is 100)

wp-rocket/inc/Engine/Common/Queue/RUCSSQueueRunner.php

Lines 64 to 73 in 0ed866c

	/**
	* Filters the clean batch size.
	*
	* @since 3.11.0.5
	*
	* @param int $batch_size Batch size.
	*
	* @return int
	*/
	$batch_size = (int) apply_filters( 'rocket_action_scheduler_clean_batch_size', 100, $this->group );

so with each CRON run (every minute), 100 log items will be cleaned.

[jamiematrix]

We're on v3.11.3 and the rocket_rucss_pending_jobs_cron hook is flooding the actions table. I've checked the source and can see the fix above is in there but it's clearly not working.
Tried to remove the rows from the WPAdmin UI but I'm not able to delete even one job.

Looking through the UI in WordPress it currently lists 10 rows per page, each of those 10 rows appear to be created at the same time. This would suggest there are more than 10 jobs being created each minute so I would assume over time cleaning 100 jobs per minute wouldn't be enough?

[engahmeds3ed]

We're on v3.11.3 and the rocket_rucss_pending_jobs_cron hook is flooding the actions table. I've checked the source and can see the fix above is in there but it's clearly not working. Tried to remove the rows from the WPAdmin UI but I'm not able to delete even one job.

Looking through the UI in WordPress it currently lists 10 rows per page, each of those 10 rows appear to be created at the same time. This would suggest there are more than 10 jobs being created each minute so I would assume over time cleaning 100 jobs per minute wouldn't be enough?

Can you plz reach WP Rocket support at support[at]wp-rocket.me they have tools to easily remove all logs at once.

[jamiematrix]

We're on v3.11.3 and the rocket_rucss_pending_jobs_cron hook is flooding the actions table. I've checked the source and can see the fix above is in there but it's clearly not working. Tried to remove the rows from the WPAdmin UI but I'm not able to delete even one job.
Looking through the UI in WordPress it currently lists 10 rows per page, each of those 10 rows appear to be created at the same time. This would suggest there are more than 10 jobs being created each minute so I would assume over time cleaning 100 jobs per minute wouldn't be enough?

Can you plz reach WP Rocket support at support[at]wp-rocket.me they have tools to easily remove all logs at once.

Will do. Just worked out there have been 19,000+ rows added in the last 15 minutes

[jamiematrix]

No reply as of yet.
I changed the number of log items to be cleaned to 2000 and it appears to have made no difference. Possibly made it worse