Fix indentation in PhpArrayGenerator.php

features/makephp.feature

@@ -305,7 +305,7 @@ Feature: Generate PHP files from PO files
     And the foo-plugin/foo-plugin-de_DE.l10n.php file should contain:
       """
       <?php
-        return [
+      return [
           'domain' => 'foo-plugin',
           'plural-forms' => 'nplurals=2; plural=(n != 1);',
           'language' => 'de_DE',
@@ -317,5 +317,5 @@ Feature: Generate PHP files from PO files
               'Hello' => 'Hallo',
               'You have %d new message' => 'Du hast %d neue Nachricht' . "\0" . 'Du hast %d neue Nachrichten',
           ],
-        ];
+      ];
       """

src/PhpArrayGenerator.php

@@ -31,7 +31,7 @@ public static function toString( Translations $translations, array $options = []
 			$exported_array = static::var_export( $array );
 		}
 
-		return '<?php' . PHP_EOL . '  return ' . $exported_array . ';';
+		return '<?php' . PHP_EOL . 'return ' . $exported_array . ';';
 	}
 
 	/**
@@ -175,22 +175,21 @@ private static function var_export( $value ) {
 
 	/**
 	 * Outputs or returns a parsable string representation of a variable.
-	 * @since 4.0.0
 	 *
 	 * @param mixed $value The variable you want to export.
 	 * @param int   $level The current indentation level.
-	 * @param int   $indentation The number of spaces for indentation. Default is 4.
+	 * @param int   $indentation The number of spaces for indentation.
 	 * @return string The variable representation.
 	 */
-	private static function pretty_export( $values, $indentation = 2 ) {
+	private static function pretty_export( $values, $indentation = 4, $is_top_level = true ) {
 		$result = '[' . PHP_EOL;
 		$indent = str_repeat( ' ', $indentation );
 
 		foreach ( $values as $key => $value ) {
 			$result .= $indent . str_repeat( ' ', $indentation ) . "'$key' => ";
 
 			if ( is_array( $value ) ) {
-				$result .= self::pretty_export( $value, $indentation + $indentation );
+				$result .= self::pretty_export( $value, $indentation + $indentation, false );
 			} elseif ( strpos( $value, "\0" ) !== false ) {
 				$parts   = explode( "\0", $value );
 				$result .= "'" . implode( "' . \"\\0\" . '", array_map( 'addslashes', $parts ) ) . "'";
@@ -201,7 +200,7 @@ private static function pretty_export( $values, $indentation = 2 ) {
 			$result .= ',' . PHP_EOL;
 		}
 
-		$result .= $indent . ']';
+		$result .= $is_top_level ? ']' : $indent . ']';
 		return $result;
 	}
 }