Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Extra metadata in constructed type and DBCDStorage #30

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

KalopsiaTwilight
Copy link
Contributor

This PR adds in three pieces of metadata for consumers of DBCD:

  • Table and Column referenced by a reference field with a ForeignReferenceAttribute on the type's field.
  • Size in bits allocated to a column in WDC formats via ColumnMeta with a SizeInBitsAttribute on type's field.
  • The LayoutHash belonging to a DBCDStorage instance.

This is a metadata I am particularly interested for the WDBXEditor2 to be able to provide extra information in the editor and possibly limit the allowed size of integers for instance. I think these pieces of metadata could be generally useful to consumers of DBCD and fits in with the other metadata provided via Attributes atm.

@Marlamin Marlamin merged commit 02c1b58 into wowdev:master Jan 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants