Issue306 bug in optimise energy profile

CHANGELOG.md

@@ -5,7 +5,13 @@ our [project board](https://github.com/users/wouterpeere/projects/2) on GitHub.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
-## [2.3.0] - unpublished
+## [2.3.1] - unpublished
+
+## Fixed
+
+- Problem with optimise energy profile (issue #306).
+
+## [2.3.0] - 2024-11-05
 
 ## Added
 
@@ -354,6 +360,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 - fixed bug in interpolation
 
+[2.3.0]: https://github.com/wouterpeere/GHEtool/compare/v2.2.2...v2.3.0
+
 [2.2.2]: https://github.com/wouterpeere/GHEtool/compare/v2.2.1...v2.2.2
 
 [2.2.1]: https://github.com/wouterpeere/GHEtool/compare/v2.2.0...v2.2.1

GHEtool/Methods/optimise_load_profile.py

@@ -248,8 +248,8 @@ def optimise_load_profile_energy(
     borefield.load = monthly_load
 
     # store initial monthly peak loads
-    peak_heating = monthly_load.monthly_peak_heating_simulation_period
-    peak_cooling = monthly_load.monthly_peak_cooling_simulation_period
+    peak_heating = copy.copy(monthly_load.monthly_peak_heating_simulation_period)
+    peak_cooling = copy.copy(monthly_load.monthly_peak_cooling_simulation_period)
 
     for i in range(12 * borefield.load.simulation_period):
         # set iteration criteria

GHEtool/test/methods/method_data.py

@@ -503,8 +503,8 @@
                                                    21.65199, 35.8583, 56.14555, 61.92114,
                                                    name='Optimise load profile (stuck in loop) (power, hourly)',
                                                    power=True, hourly=True))
-list_of_test_objects.add(OptimiseLoadProfileObject(borefield, load, 146, 89.1681, 97.6848,
-                                                   56.49199, 71.1038, 55.13048, 66.55643,
+list_of_test_objects.add(OptimiseLoadProfileObject(borefield, load, 146, 89.31225880363472, 98.37453537405028,
+                                                   56.49199, 74.7635850227125, 54.86173917367975, 56.577818731384966,
                                                    name='Optimise load profile (stuck in loop) (energy)', power=False))
 
 ground_data = GroundFluxTemperature(3, 10)
@@ -581,7 +581,21 @@
                                                    512.6954920945816,
                                                    name='Optimise load profile (eer combined) (power)', power=True,
                                                    hourly=False))
-list_of_test_objects.add(OptimiseLoadProfileObject(borefield, load, 146, 38.165390819460434, 4.08828744800462,
-                                                   75.9124206410309, 86.06503815919983, 631.1307699700886, 535.936136,
+list_of_test_objects.add(OptimiseLoadProfileObject(borefield, load, 146, 50.187981717163034, 12.82812330930278,
+                                                   95.636899472386, 66.33595162152281, 603.0319153178363,
+                                                   509.73531422797737,
                                                    name='Optimise load profile (eer combined) (energy)', power=False,
                                                    hourly=False))
+
+data = GroundFluxTemperature(1.8, 9.7, flux=0.08)
+borefield = Borefield()
+borefield.set_ground_parameters(data)
+borefield.Rb = 0.131
+borefield.create_rectangular_borefield(3, 5, 6, 6, 100, 1, 0.07)
+load = HourlyBuildingLoad(efficiency_heating=4.5, efficiency_cooling=20)
+load.load_hourly_profile(FOLDER.joinpath("test\methods\hourly_data\\auditorium.csv"), header=True, separator=";",
+                         col_cooling=0, col_heating=1)
+list_of_test_objects.add(OptimiseLoadProfileObject(borefield, load, 100, 100.0, 92.80988709011142,
+                                                   25.315, 42.463997436869896, 0.0, 64.1435824039379,
+                                                   name='Optimise load profile (auditorium) (energy)', power=False,
+                                                   hourly=False))

GHEtool/test/methods/test_methods.py

@@ -66,7 +66,6 @@ def test_optimise(input, result):
                              np.sum(load.hourly_heating_load_simulation_period) * 100
     _percentage_injection = np.sum(borefield_load.hourly_cooling_load_simulation_period) / \
                             np.sum(load.hourly_cooling_load_simulation_period) * 100
-
     assert np.isclose(_percentage_extraction, percentage_extraction)
     assert np.isclose(_percentage_injection, percentage_injection)
     assert np.isclose(borefield_load.max_peak_extraction, peak_extraction_geo)

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = GHEtool
-version = 2.3.0
+version = 2.3.1.dev0
 author = Wouter Peere
 author_email = [email protected]
 description = Python package for borefield sizing